Skip to content

fix(Invidious) add notifications config option#13128

Merged
stavros-k merged 2 commits intotrueforge-org:masterfrom
tuxpizza:invidious-notifications
Oct 1, 2023
Merged

fix(Invidious) add notifications config option#13128
stavros-k merged 2 commits intotrueforge-org:masterfrom
tuxpizza:invidious-notifications

Conversation

@tuxpizza
Copy link
Contributor

@tuxpizza tuxpizza commented Oct 1, 2023

Add enable_user_notifications config option to Invidious

This will allow you to toggle enable_user_notifications on or off (default on) via iv-org/invidious#3473

⚒️ Fixes #13125

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?
Installed the helm chart locally with no errors

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

@tuxpizza tuxpizza requested a review from a team October 1, 2023 05:37
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2023

CLA assistant check
All committers have signed the CLA.

@tuxpizza tuxpizza changed the title Invidious notifications Invidious notifications config option Oct 1, 2023
@xstar97 xstar97 changed the title Invidious notifications config option fix(Invidious) add notifications config option Oct 1, 2023
@stavros-k stavros-k merged commit bf0e3b7 into trueforge-org:master Oct 1, 2023
@stavros-k
Copy link
Member

@all-contributors please add @tuxpizza for code

@allcontributors
Copy link
Contributor

@stavros-k

I've put up a pull request to add @tuxpizza! 🎉

stavros-k pushed a commit that referenced this pull request Oct 1, 2023
Adds @tuxpizza as a contributor for code.

This was requested by stavros-k [in this
comment](#13128 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@truecharts-admin
Copy link
Contributor

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@trueforge-org trueforge-org locked as resolved and limited conversation to collaborators Oct 9, 2023
@tuxpizza tuxpizza deleted the invidious-notifications branch October 9, 2023 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Invidious Notifications option

4 participants